Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in covariate names #140

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

trietmnj
Copy link

@trietmnj trietmnj commented Jan 1, 2024

Covariate names were stored as x_name in MGWRResult instead of the name_x convention used everywhere else, leading to MGWRResult.summary(), summaryGLM(), and summaryMGWR() unable to display the covariate names even if they are specified. Just a simple typo correction.

mgwr/mgwr/gwr.py

Line 1284 in 5b484ef

summary = summaryModel(self) + summaryGLM(self) + summaryGWR(self)

if self.name_x is not None:

if self.name_x is not None:

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! Thanks for noticing!

@TaylorOshan TaylorOshan merged commit f7b7919 into pysal:master Jan 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants