Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: simplify calculation of Simpson diversity #320

Merged
merged 3 commits into from Dec 23, 2021

Conversation

martinfleis
Copy link
Member

I realised that the simpson_diversity helper function can be much simpler than it was. Also, categories keyword made no difference to the calculation so I dropped it from the helper. It is still part of the signature of Simpson though, to avoid any breakage. I assume that it will get cleaned with the API revamp (#308).

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #320 (1b6a816) into main (8d341e5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   95.97%   95.99%   +0.02%     
==========================================
  Files          13       13              
  Lines        2832     2822      -10     
==========================================
- Hits         2718     2709       -9     
+ Misses        114      113       -1     
Impacted Files Coverage Δ
momepy/diversity.py 98.00% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d341e5...1b6a816. Read the comment docs.

@jGaboardi jGaboardi merged commit 90ce789 into pysal:main Dec 23, 2021
@martinfleis martinfleis deleted the simpson branch January 5, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants