Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: simplify orientation calculation #349

Merged
merged 1 commit into from Mar 16, 2022
Merged

Conversation

martinfleis
Copy link
Member

Simplification (and likely a speedup) of computation of a deviation from cardinal directions from an azimuth.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #349 (1ab64d2) into main (ae0d7dc) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   95.89%   95.52%   -0.38%     
==========================================
  Files          13       13              
  Lines        2829     2815      -14     
==========================================
- Hits         2713     2689      -24     
- Misses        116      126      +10     
Impacted Files Coverage Δ
momepy/distribution.py 97.40% <100.00%> (-0.15%) ⬇️
momepy/preprocessing.py 87.37% <0.00%> (-1.67%) ⬇️
momepy/elements.py 95.19% <0.00%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae0d7dc...1ab64d2. Read the comment docs.

@jGaboardi jGaboardi changed the title REF: simplify orientation calculatoin REF: simplify orientation calculation Mar 16, 2022
@jGaboardi jGaboardi merged commit b347429 into pysal:main Mar 16, 2022
@martinfleis martinfleis deleted the orient branch March 16, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants