Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: create preprocessing section #393

Merged
merged 4 commits into from Sep 11, 2022
Merged

Conversation

martinfleis
Copy link
Member

This creates a preprocessing section in the user guide and moves and renames existing preprocessing notebook. I have also added redirection from the old location of the notebook to the new one, though I am not sure it works now :). Want to see the RTD build.

@gregmaya @gsagostini please put your notebooks in this section once this gets merged.

@martinfleis martinfleis self-assigned this Sep 11, 2022
@martinfleis
Copy link
Member Author

I have also added redirection from the old location of the notebook to the new one, though I am not sure it works now :)

It does not, even though it is 1:1 copy from geopandas. Will need to debug.

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things for the simple_preprocessing notebook:

  • Can we rerun for consecutive cell numbering?
  • Correct spelling in text above cell 29:
    • "... in this situation as we are nor -> not snapping endpoints to endpoints."

@jGaboardi
Copy link
Member

@martinfleis is this ready to merge or does it still need debugging as you mentioned above?

@martinfleis
Copy link
Member Author

I still need to figure out the redirect. Working on it right now.

@jGaboardi jGaboardi self-requested a review September 11, 2022 18:59
@martinfleis
Copy link
Member Author

Fixed, merging.

@martinfleis martinfleis merged commit afcb85b into pysal:main Sep 11, 2022
@martinfleis martinfleis deleted the prepro_docs branch September 11, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants