Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scour docs for consistency, grammar, etc. #416

Merged
merged 11 commits into from
Sep 19, 2022
Merged

Conversation

jGaboardi
Copy link
Member

Resolves #414, (mostly). All files have been reviewed except preprocessing.py, which I will leave until after #377 and #396.

@jGaboardi jGaboardi self-assigned this Sep 19, 2022
momepy/dimension.py Outdated Show resolved Hide resolved
momepy/dimension.py Outdated Show resolved Hide resolved
momepy/diversity.py Outdated Show resolved Hide resolved
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton! Just two minor notes in the code.

@martinfleis
Copy link
Member

heh, you were faster to fix that than I to finish the review :D

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit f2d998e into pysal:main Sep 19, 2022
@jGaboardi jGaboardi deleted the doc_scour branch September 19, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scour docstrings (grammar, punctuation, etc.)
2 participants