-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: support single-part multipolygons in Squareness and CentroidCorners #507
Conversation
thanks for this! I understand how useful it could be in some cases but am not sure if it doesn't bring a bit opaque inconsistency when it does work for some MultiPolygons but not for the other. @jGaboardi what are your thoughts? |
It seems to me that the opaque inconsistency can be cleared up with several more words in the docstring (and maybe a thrown warning silenced by default at the absolute most). My reasoning here is that the MultiPolygons that are being operated on are not true MultiPolygons, they are single Polygons mislabeled (perhaps not the best terminology) as being MultiPolygons. Maybe something like:
And tests failing due to #508, not this PR, correct? |
Okay, let's give it a shot following @jGaboardi's suggestion.
Yes. |
Adds more explanation regarding application to MultiPolygons Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Adds more explanatory text on application to MultiPolygons Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Is there appetite to support MultiPolygons for Squareness and CentroidCorners?