Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add FaceArtifacts #510

Merged
merged 6 commits into from
Aug 30, 2023
Merged

ENH: add FaceArtifacts #510

merged 6 commits into from
Aug 30, 2023

Conversation

martinfleis
Copy link
Member

Adding FaceArtifacts exposing the workflow from the upcoming paper by myself and @anastassiavybornova.

I still need to figure out how to test this since the method works for large metro areas but not for smaller samples. It needs the critical mass of elements. I will play with it if I find some useful samples.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #510 (943f490) into main (4f1176a) will increase coverage by 0.3%.
Report is 1 commits behind head on main.
The diff coverage is 96.8%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #510     +/-   ##
=======================================
+ Coverage   97.2%   97.5%   +0.3%     
=======================================
  Files         24      24             
  Lines       4110    4176     +66     
=======================================
+ Hits        3996    4072     +76     
+ Misses       114     104     -10     
Files Changed Coverage Δ
momepy/preprocessing.py 93.8% <94.7%> (+0.1%) ⬆️
momepy/tests/test_preprocess.py 100.0% <100.0%> (ø)

... and 5 files with indirect coverage changes

@martinfleis martinfleis self-assigned this Aug 28, 2023
@martinfleis
Copy link
Member Author

@anastassiavybornova can I ask for your review as well?

@martinfleis martinfleis marked this pull request as ready for review August 28, 2023 21:22
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems sound, as far as I can tell. I will leave it up to @anastassiavybornova to review and approve.

momepy/preprocessing.py Outdated Show resolved Hide resolved
momepy/preprocessing.py Outdated Show resolved Hide resolved
@jGaboardi jGaboardi added the enhancement New feature or request label Aug 29, 2023
Copy link

@anastassiavybornova anastassiavybornova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@martinfleis martinfleis merged commit 50f7fe3 into pysal:main Aug 30, 2023
11 checks passed
@martinfleis martinfleis deleted the banana branch August 30, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants