Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes on plans with the rest of dimension classes #536

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

martinfleis
Copy link
Member

This is more a discussion than actual PR. I went through dimension.py and thought about the future of all of the classes we have there. There are two main questions

  1. Do we keep these as thin wrappers around Graph.lag or point directly to lag?
  2. What should be moved to libpysal and how?

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.7%. Comparing base (29c0e5d) to head (b38fa2e).
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #536     +/-   ##
=======================================
+ Coverage   97.5%   97.7%   +0.2%     
=======================================
  Files         26      32      +6     
  Lines       4189    4996    +807     
=======================================
+ Hits        4086    4882    +796     
- Misses       103     114     +11     
Files Coverage Δ
momepy/dimension.py 98.7% <ø> (ø)

... and 17 files with indirect coverage changes

@martinfleis
Copy link
Member Author

I am going to merge this to keep the notes in sync with the development

@martinfleis martinfleis marked this pull request as ready for review April 24, 2024 08:30
@martinfleis martinfleis merged commit cf73295 into pysal:main Apr 24, 2024
13 checks passed
@martinfleis martinfleis deleted the dimension_cont branch April 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant