Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add orientation and shared_walls functional versions #553

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

martinfleis
Copy link
Member

Orientation:

    # buildings
    # old: 3.23 s ± 77 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
    # new: 932 ms ± 12.5 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
    # streets
    # old: 374 ms ± 5.56 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
    # new: 62 ms ± 681 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)

Shared walls:

    # 8.68 s ± 28.7 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
    # 10.3 s ± 17.2 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

This is slower but it does not cause erroneous results coming from overlapping polygons.

@martinfleis martinfleis added the enhancement New feature or request label Feb 29, 2024
@martinfleis martinfleis added this to the 0.8.0 milestone Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.5%. Comparing base (4037c70) to head (59c5127).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #553     +/-   ##
=======================================
+ Coverage   97.4%   97.5%   +0.1%     
=======================================
  Files         26      30      +4     
  Lines       4328    4712    +384     
=======================================
+ Hits        4214    4592    +378     
- Misses       114     120      +6     
Files Coverage Δ
momepy/__init__.py 100.0% <100.0%> (ø)
momepy/functional/tests/test_distribution.py 100.0% <100.0%> (ø)
momepy/functional/_distribution.py 85.0% <85.0%> (ø)

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small typo.

momepy/functional/_distribution.py Outdated Show resolved Hide resolved
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
@martinfleis martinfleis merged commit 452298d into pysal:main Feb 29, 2024
11 checks passed
@martinfleis martinfleis deleted the orient_sw branch March 21, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants