Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add alignment to the new API #554

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

martinfleis
Copy link
Member

Functional version of alignment based on libpysal Graph. It is fast. 282x faster than the original.

 61.6 ms ± 3.63 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
 17.4 s ± 1.13 s per loop (mean ± std. dev. of 7 runs, 1 loop each)

@martinfleis martinfleis added the enhancement New feature or request label Mar 6, 2024
@martinfleis martinfleis added this to the 0.8.0 milestone Mar 6, 2024
@martinfleis martinfleis self-assigned this Mar 6, 2024
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jGaboardi jGaboardi merged commit 3a76ad6 into pysal:main Mar 6, 2024
11 checks passed
@martinfleis martinfleis deleted the alignment branch March 6, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants