Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: refactor tessellation #559

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Conversation

martinfleis
Copy link
Member

@martinfleis martinfleis commented Mar 21, 2024

WIP but the code works already.

For morphological tessellation:

new: 8min 43s
old: 27min 8s

For enclosed tessellation:

    # Old with Dask
    # CPU times: user 10.5 s, sys: 1.57 s, total: 12.1 s
    # Wall time: 6min 36s

    # New n_jobs=1
    # CPU times: user 2min 48s, sys: 547 ms, total: 2min 48s
    # Wall time: 2min 50s

    # New n_jobs=-1
    # CPU times: user 7.11 s, sys: 857 ms, total: 7.97 s
    # Wall time: 46.2 s

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 98.38710% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.7%. Comparing base (4037c70) to head (705eb7f).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #559     +/-   ##
=======================================
+ Coverage   97.4%   97.7%   +0.3%     
=======================================
  Files         26      32      +6     
  Lines       4328    4942    +614     
=======================================
+ Hits        4214    4826    +612     
- Misses       114     116      +2     
Files Coverage Δ
momepy/__init__.py 100.0% <100.0%> (ø)
momepy/functional/tests/test_elements.py 100.0% <100.0%> (ø)
momepy/functional/_elements.py 96.3% <96.3%> (ø)

@martinfleis martinfleis marked this pull request as ready for review March 22, 2024 15:10
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, but LGTM.

momepy/functional/_elements.py Outdated Show resolved Hide resolved
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
@jGaboardi jGaboardi merged commit 25a07eb into pysal:main Mar 22, 2024
13 checks passed
@martinfleis martinfleis deleted the tessellation_ref branch March 22, 2024 19:15
@martinfleis martinfleis added enhancement New feature or request and removed refactor labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants