-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: speed-up describe using numba #571
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
=======================================
+ Coverage 97.4% 97.7% +0.4%
=======================================
Files 26 35 +9
Lines 4328 5099 +771
=======================================
+ Hits 4214 4984 +770
- Misses 114 115 +1
|
Yes, I think we can add a note to the |
Follow-up on #570
Had to reimplement
mode
to actually compile based on numba/numba#2959 (comment).Timings compared to #570
How would you set the CI envs to test numba and fallback options? I am not a big fan of having everything twice. Would 1 env without numba be enough in your experience?