Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: compatibility, warning cleanup, test lint #574

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

martinfleis
Copy link
Member

I wanted to primarily cleanup warnings from our CI. So some changes related to that, some changes related to compatibility (FutureWarning removal), plus linting of tests which was for some reason disabled.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 98.18182% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.8%. Comparing base (4037c70) to head (9d1d944).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #574     +/-   ##
=======================================
+ Coverage   97.4%   97.8%   +0.4%     
=======================================
  Files         26      37     +11     
  Lines       4328    5160    +832     
=======================================
+ Hits        4214    5045    +831     
- Misses       114     115      +1     
Files Coverage Δ
momepy/coins.py 95.3% <ø> (ø)
momepy/dimension.py 98.8% <100.0%> (+<0.1%) ⬆️
momepy/functional/_elements.py 100.0% <100.0%> (ø)
momepy/functional/tests/test_elements.py 100.0% <ø> (ø)
momepy/intensity.py 99.5% <100.0%> (+<0.1%) ⬆️
momepy/preprocessing.py 93.4% <100.0%> (+0.1%) ⬆️
momepy/tests/test_dimension.py 100.0% <ø> (ø)
momepy/tests/test_distribution.py 100.0% <100.0%> (ø)
momepy/tests/test_diversity.py 100.0% <100.0%> (ø)
momepy/tests/test_elements.py 100.0% <100.0%> (ø)
... and 9 more

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note/clarification, but LGTM.

momepy/tests/test_weights.py Show resolved Hide resolved
@jGaboardi jGaboardi merged commit 36b13f8 into pysal:main Apr 29, 2024
14 checks passed
@martinfleis martinfleis deleted the compat branch April 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants