Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting & formatting for benchmarks/* and docs/* #578

Merged
merged 10 commits into from
May 13, 2024

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented May 12, 2024

@jGaboardi jGaboardi self-assigned this May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.8%. Comparing base (4037c70) to head (a9fec79).
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #578     +/-   ##
=======================================
+ Coverage   97.4%   97.8%   +0.4%     
=======================================
  Files         26      37     +11     
  Lines       4328    5160    +832     
=======================================
+ Hits        4214    5045    +831     
- Misses       114     115      +1     

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set different line length for docs? Because using 88, some cells won't fit, like the first one after this section. I would like to avoid this in the documentation. It seems that the limit there is 80 characters.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@jGaboardi
Copy link
Member Author

this section

Yes, seems like we can accomplish this with a subset ruff.toml in the docs/ directory.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit 7c1d30a into pysal:main May 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more complete linting & formatting - docs & benchmarks
2 participants