Functional blocks #580
Merged
Functional blocks #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
=======================================
+ Coverage 97.4% 97.9% +0.5%
=======================================
Files 26 37 +11
Lines 4328 5491 +1163
=======================================
+ Hits 4214 5375 +1161
- Misses 114 116 +2
|
martinfleis
reviewed
May 16, 2024
momepy/functional/_elements.py
Outdated
| tessellation: GeoDataFrame, | ||
| edges: GeoDataFrame, | ||
| buildings: GeoDataFrame, | ||
| id_name: str = "bID", |
There was a problem hiding this comment.
no need for that, rely on index
martinfleis
requested changes
May 31, 2024
momepy/functional/_elements.py
Outdated
| edges: GeoDataFrame, | ||
| buildings: GeoDataFrame, | ||
| id_name: str = "bID", | ||
| ): |
martinfleis
reviewed
Jun 4, 2024
There was a problem hiding this comment.
We should also make a note that this assumes morphological tessellation and 1:1 relationship between buildings and cells. With enclosed tessellation, those cells that do not have buildings would cause a trouble here. No need to change anything, just adding a note to the docstring would do.
momepy/functional/_elements.py
Outdated
|
|
||
| # assign block ids to buildings and tessellations | ||
| centroids_w_bl_id2 = gpd.sjoin(buildings_c, blocks, how="left", predicate="within") | ||
| # return blocks, centroids_w_bl_id2 |
There was a problem hiding this comment.
Suggested change
| # return blocks, centroids_w_bl_id2 |
martinfleis
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functional implementation of blocks, the code is pretty much the same as the OO version