BUG/ENH: support custom enclosure index is in tessellation and GeoDataFrame as enclosure input #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=======================================
+ Coverage 97.4% 97.8% +0.5%
=======================================
Files 26 37 +11
Lines 4328 5362 +1034
=======================================
+ Hits 4214 5246 +1032
- Misses 114 116 +2
|
u3ks
approved these changes
May 20, 2024
u3ks
pushed a commit
to u3ks/momepy
that referenced
this pull request
May 31, 2024
…aFrame as enclosure input (pysal#582) * BUG: ensure custom enclosure index is supported in tessellation * support both series and datarame as enclosures input * tests * typing
martinfleis
added a commit
that referenced
this pull request
Jun 12, 2024
* functional area_ratio * Update momepy/functional/_intensity.py Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net> * BUG/ENH: support custom enclosure index is in tessellation and GeoDataFrame as enclosure input (#582) * BUG: ensure custom enclosure index is supported in tessellation * support both series and datarame as enclosures input * tests * typing * ENH: adaptive buffer as a tessellation limit (#590) * ENH: adaptive buffer as a tessellation limit * pass kwargs * version checks and tests * fix expected * pr changes * test versioning --------- Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indexing was broken for non-default RangeIndex. Also, given we currently return enclosures as gdf, it is handy to support it out of the box.