Functional count #585
Closed
Functional count #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
=======================================
+ Coverage 97.4% 97.9% +0.5%
=======================================
Files 26 37 +11
Lines 4328 5434 +1106
=======================================
+ Hits 4214 5318 +1104
- Misses 114 116 +2
|
martinfleis
requested changes
May 31, 2024
momepy/functional/_intensity.py
Outdated
| def count( | ||
| left: GeoDataFrame, | ||
| right: GeoDataFrame, | ||
| right_group_key: Series | np.ndarray, |
There was a problem hiding this comment.
Suggested change
| right_group_key: Series | np.ndarray, | |
| aggregation_key: Series | np.ndarray, |
as per #583
momepy/functional/_intensity.py
Outdated
|
|
||
| def count( | ||
| left: GeoDataFrame, | ||
| right: GeoDataFrame, |
There was a problem hiding this comment.
Do we actually need right at all? Doesn't the grouping have all the info we need?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional implmentation of mm.Count
this function has the same logic as area_ratio, but the weight is inferred from the geometry type.
Potentially, it could be left to the user to implement it with a call to describe_reached (or two if the result should be weighted). (similarly to arearatio)