Functional density #586
Merged
Functional density #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=======================================
+ Coverage 97.4% 97.9% +0.5%
=======================================
Files 26 37 +11
Lines 4328 5612 +1284
=======================================
+ Hits 4214 5492 +1278
- Misses 114 120 +6
|
martinfleis
requested changes
May 31, 2024
momepy/functional/_intensity.py
Outdated
|
|
||
|
|
||
| def density( | ||
| values: Series | np.ndarray, areas: Series | np.ndarray, graph: Graph |
There was a problem hiding this comment.
Suggested change
| values: Series | np.ndarray, areas: Series | np.ndarray, graph: Graph | |
| y: Series | NDArray[np.float_], area: Series | NDArray[np.float_], graph: Graph |
momepy/functional/_intensity.py
Outdated
|
|
||
| stats = graph.apply( | ||
| pd.concat((values, areas.rename("area")), axis=1), | ||
| lambda x: (x.loc[:, x.columns != "area"].sum() / x["area"].sum()), |
There was a problem hiding this comment.
are you assuming here that values can be 2d and calculate density for multiple vars at one go? That is undocumented and goes against typing.
martinfleis
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar functionality to count and arearatio.
Similarly, it could be implemented by either us or the users using two calls to describe_reached.