Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Street profile #593

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Street profile #593

merged 10 commits into from
Jun 12, 2024

Conversation

u3ks
Copy link
Collaborator

@u3ks u3ks commented Jun 10, 2024

funcitonal street profile. The equivalence tests have rtol between .01 and 1, to account for the different segmentation strategies.

@u3ks u3ks requested a review from martinfleis June 10, 2024 12:16
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (f31dc4c).
Report is 35 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #593     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      37     +11     
  Lines       4328    5987   +1659     
=======================================
+ Hits        4214    5865   +1651     
- Misses       114     122      +8     
Files Coverage Δ
momepy/functional/_dimension.py 100.0% <100.0%> (ø)
momepy/functional/tests/test_dimension.py 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

momepy/functional/_dimension.py Outdated Show resolved Hide resolved
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
momepy/functional/tests/test_dimension.py Show resolved Hide resolved
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
u3ks and others added 2 commits June 11, 2024 16:48
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
@u3ks u3ks requested a review from martinfleis June 11, 2024 15:54
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
momepy/functional/tests/test_dimension.py Outdated Show resolved Hide resolved
@u3ks u3ks requested a review from martinfleis June 12, 2024 13:27
momepy/functional/_dimension.py Outdated Show resolved Hide resolved
@martinfleis martinfleis merged commit 6df41c3 into pysal:main Jun 12, 2024
14 checks passed
@martinfleis martinfleis added enhancement New feature or request and removed refactor labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants