Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: execute notebooks and ensure they're tested #603

Merged
merged 5 commits into from
Jun 15, 2024

Conversation

martinfleis
Copy link
Member

This PR contains

  • automatically executed notebooks to ensure no issues left from refactoring
  • two minor fixes in user guide
  • fix user guide testing
    • execute them all
    • switch to latest again
    • use geopandas main in latest until 1.0 is out

@martinfleis martinfleis self-assigned this Jun 15, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (b92cea6).
Report is 43 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #603     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      37     +11     
  Lines       4328    6068   +1740     
=======================================
+ Hits        4214    5946   +1732     
- Misses       114     122      +8     

@martinfleis
Copy link
Member Author

for a reference - https://github.com/pysal/momepy/actions/runs/9527171008/job/26263466991 took 23 minutes

@martinfleis martinfleis merged commit e6b0abf into pysal:main Jun 15, 2024
14 checks passed
@martinfleis martinfleis deleted the execute branch June 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants