BUG: fix describe_ function when count is not present #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
+ Coverage 97.4% 98.0% +0.6%
=======================================
Files 26 37 +11
Lines 4328 6078 +1750
=======================================
+ Hits 4214 5956 +1742
- Misses 114 122 +8
|
martinfleis
changed the title
martinfleis
approved these changes
Jun 17, 2024
|
Is this something that also needs to be included in Graph.describe? |
|
No, Graph.describe doesnt modify the output of pandas.agg, here we do to make it compatible with the old functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a fix for a small issue with the mm.describe_* functions, where they expect a count to always be calculated