-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster node density #609
Merged
Merged
Faster node density #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
+ Coverage 97.4% 98.0% +0.6%
=======================================
Files 26 37 +11
Lines 4328 6079 +1751
=======================================
+ Hits 4214 5957 +1743
- Misses 114 122 +8
|
martinfleis
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
martinfleis
reviewed
Jun 17, 2024
martinfleis
approved these changes
Jun 17, 2024
One more thing, can you update API docs? Removing the old one and adding the new to the proper section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the node density functionality to the graph module and use networkx to compute it.
The current implementation scales horribly and on larger graphs takes hours, since all edges have to be filtered multiple times with np.in1d.
Getting the exact timing is a bit messy since subgraphs and higher order pysal have to be precomuted and affect the time.
The new implementation takes around <20ish mintues on a graph with ~500k nodes and 2mil edges, together with the other mm.subgraph computations.
For smaller datasets the current implementation + calculating a higher order graph ~ the new networkx implementation.