Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: ruff user guide #613

Merged
merged 1 commit into from
Jun 18, 2024
Merged

DOC: ruff user guide #613

merged 1 commit into from
Jun 18, 2024

Conversation

martinfleis
Copy link
Member

@jGaboardi any idea why it was not picked up by pre-commit?

@martinfleis martinfleis added the dependencies Pull requests that update a dependency file label Jun 18, 2024
@martinfleis martinfleis self-assigned this Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (683cd6f).
Report is 49 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #613     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      38     +12     
  Lines       4328    6086   +1758     
=======================================
+ Hits        4214    5964   +1750     
- Misses       114     122      +8     

@martinfleis martinfleis merged commit 8e34048 into pysal:main Jun 18, 2024
15 checks passed
@martinfleis martinfleis deleted the ruff-docs branch June 18, 2024 13:56
@jGaboardi
Copy link
Member

Not 100% sure, but let's try to explicitly add the path in .pre-commit-config.yaml, like here in spopt. So ours would look like:

files: "momepy\/|docs\/"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants