Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: do not return building_id from generate_blocks #627

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

u3ks
Copy link
Collaborator

@u3ks u3ks commented Jun 20, 2024

No description provided.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (18c7345).
Report is 61 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #627     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      38     +12     
  Lines       4328    6221   +1893     
=======================================
+ Hits        4214    6095   +1881     
- Misses       114     126     +12     
Files Coverage Δ
momepy/functional/_elements.py 99.2% <100.0%> (ø)
momepy/functional/tests/test_elements.py 99.0% <100.0%> (ø)

@u3ks u3ks requested a review from martinfleis June 20, 2024 16:40
@martinfleis martinfleis changed the title remove buildings_id REF: do not return building_id from generate_blocks Jun 20, 2024
@martinfleis martinfleis merged commit 81ba419 into pysal:main Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants