REF: reimplement mrr on top of shapely #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=====================================
Coverage 69.4% 69.4%
=====================================
Files 12 12
Lines 1769 1767 -2
=====================================
- Hits 1228 1227 -1
+ Misses 541 540 -1
|
|
@martinfleis Is this ready for review? |
|
@jGaboardi yup! Wasn't sure who's responsible here :). |
|
Seems like you, @knaaptime, and @sjsrey have made the most recent commits. I'll add them for review as well. |
jGaboardi
reviewed
Jan 31, 2024
jGaboardi
approved these changes
Jan 31, 2024
knaaptime
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue seen in pysal/libpysal#681 where opencv causes installation headache. Since we already depend on shapely, there's no need to depend on OpenCV, so using shapely's minimum_rotated_rectangle, computing the angle manually and coercing the resulting array into the opencv-like order (which is the opposite compared to shapely).