localknox #136
Merged
localknox #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
knaaptime
commented
Apr 10, 2024
knaaptime
commented
- keep neighbors and identify unique clusters in local knox hotspots
- fix hotspot logic
- hotspots is correct
- add localknox hotspot tests
- update tests
- keep table values for nonsig observations in localknox hotspot
|
@jGaboardi are we ready to make 3.9 the min version and 312 the max here? |
Ya, I think even 3.10 is OK, at least according to SPEC000, but keeping 3.9 around for now wouldn't be the end of the world. |
|
worth merging this then working on the CI separately? |
I think so, but let's get a thumb up from at least 1 more dev since the PR technically is failing. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.