Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update min supported Python and testing workflow #140

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jun 15, 2024

@jGaboardi
Copy link
Member Author

jGaboardi commented Jun 15, 2024

Two One environment failing:

  • ubuntu 312-dev.yaml failing with:
    •  FAILED pointpats/tests/test_spacetime.py::TestKnoxLocal::test_explore - AssertionError: assert 3 == 5
       +  where 3 = len(OrderedDict({'[https://a.basemaps.cartocdn.com/light_all/{z}/{x}/{y}{r}.png]         (https://a.basemaps.cartocdn.com/light_all/%7Bz%7D/%7Bx%7D/%7By%7D%7Br%7D.png)': OrderedDict({'name':            'TileLayer', 'id': 'fd9b1873f553eee3a26c2d7407906f51', 'children': OrderedDict()}),      'fit_bounds_0f2b8bc330de81fe43c794b888936ed4': OrderedDict({'name': 'FitBounds', 'id':      '0f2b8bc330de81fe43c794b888936ed4', 'children': OrderedDict()}),      'geo_json_0cc3a591ba3d90e59029a9f708340340': OrderedDict({'name': 'GeoJson', 'id':      '0cc3a591ba3d90e59029a9f708340340', 'children':      OrderedDict({'geo_json_tooltip_385e76e597c37af7e5c19a3cad857447': OrderedDict({'name': 'GeoJsonTooltip', 'id':      '385e76e597c37af7e5c19a3cad857447', 'children': OrderedDict()})})})}))
      
  • windows 312-latest.yaml
    • related to the pyogrio installation.
    • might be windows specific since the Mac and Ubuntu pass without pyogrio being installed.
    • resolved

Any thoughts or ideas here?

@martinfleis
Copy link
Member

I am not sure what that explore test was supposed to test but it may be related to recent changes in folium.

The GDAL issue is a broken feedstock, we can ignore that here.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.7%. Comparing base (e152ac8) to head (573bf0b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #140     +/-   ##
=======================================
+ Coverage   69.6%   69.7%   +0.1%     
=======================================
  Files         12      12             
  Lines       1774    1775      +1     
=======================================
+ Hits        1235    1237      +2     
+ Misses       539     538      -1     

see 1 file with indirect coverage changes

@knaaptime
Copy link
Member

@jGaboardi there's a PR in your fork that will get things moving. I'm not sure what is different about the folium on 3.12 but the size of the dict containing the map contents is different.

update min supported Python and testing workflow
@jGaboardi
Copy link
Member Author

@jGaboardi there's a PR in your fork that will get things moving. I'm not sure what is different about the folium on 3.12 but the size of the dict containing the map contents is different.

done

Copy link
Member Author

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Approved"

@knaaptime knaaptime merged commit 4998440 into pysal:main Jul 4, 2024
10 checks passed
@jGaboardi jGaboardi deleted the update_min_python branch July 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump & sync min reqs [2024-06] minimum support Python [2024-06]
3 participants