Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix for K function #45

Merged
merged 2 commits into from
Dec 20, 2019
Merged

BUG: fix for K function #45

merged 2 commits into from
Dec 20, 2019

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Dec 12, 2019

This corrects the K function.

@@ -448,8 +459,7 @@ def _k(pp, intervals=10, dmin=0.0, dmax=None, d=None):
dmin : float
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dmin is not used

Copy link
Member

@weikang9009 weikang9009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you also update the jupyter notebook?

@weikang9009
Copy link
Member

I am going to merge this and update the notebook in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants