Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove codecov #1205

Closed
sjsrey opened this issue Jan 18, 2021 · 8 comments
Closed

remove codecov #1205

sjsrey opened this issue Jan 18, 2021 · 8 comments

Comments

@sjsrey
Copy link
Member

sjsrey commented Jan 18, 2021

We are testing the imports, but codecov isn't designed to see this.

In this case, codecov is more annoying than helpful. I think we should remove it from the meta package unless someone can figure out a way to make it more useful.

@knaaptime
Copy link
Member

cant see that coverage is a useful stat for the metapackage. I say we toss it

@jGaboardi
Copy link
Member

Do we want to simply turn off CodeCov or remove completely?

  • Turning off can be done like this.
  • Removing altogether is a bit more involved:
    • remove integration (Settings->Intergrations->Configure->Repository access->X)
    • remove codecov.yml
    • remove from requirements, and environments (including ci/*)
    • remove action from unittests.yml
    • other?

@sjsrey
Copy link
Member Author

sjsrey commented Jan 18, 2021

Turning off makes sense to me.

@jGaboardi
Copy link
Member

This will have to done by someone with full admin privileges.

@sjsrey
Copy link
Member Author

sjsrey commented Jan 18, 2021

i deselected pysal on the repos in our organization account that codecov reports. I'm assuming that takes care of it?

@jGaboardi
Copy link
Member

I would think so. Let's try a toy PR to check?

@sjsrey
Copy link
Member Author

sjsrey commented Jan 18, 2021

#1206

@jGaboardi
Copy link
Member

resolved in #1207

@sjsrey sjsrey closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants