Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: memory efficient and performant gini #195

Merged
merged 1 commit into from Feb 26, 2022
Merged

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Feb 25, 2022

Motivation for this and a performance evaluation are here. This replaces #170

@sjsrey sjsrey mentioned this pull request Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #195 (a48284c) into master (08de8f8) will decrease coverage by 0.17%.
The diff coverage is 26.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   81.53%   81.35%   -0.18%     
==========================================
  Files         117      117              
  Lines        3396     3417      +21     
==========================================
+ Hits         2769     2780      +11     
- Misses        627      637      +10     
Impacted Files Coverage Δ
segregation/singlegroup/gini.py 55.55% <26.92%> (-40.28%) ⬇️
segregation/_version.py 39.16% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08de8f8...a48284c. Read the comment docs.

@knaaptime
Copy link
Member

sweet

@sjsrey sjsrey merged commit 76f3e6a into pysal:master Feb 26, 2022
@renanxcortes
Copy link
Collaborator

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants