New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pygeos #210
remove pygeos #210
Conversation
Huh? How come this PR caused a failure? Anyone closer to segregation code can tell me what is wrong? |
weird. I'll dig into it thanks for putting this together |
Very strange indeed. Seems to be coming from deep within |
How and why removing the |
It is not caused by this PR. See main https://github.com/pysal/segregation/actions/runs/4642225334/jobs/8215907349. For some reason, the workflow is marked as successful even when it failed in all envs :D. |
|
i thought the continue on error was supposed to just keep running tests on all platforms even when one fails (to make sure its not isolated to windows or something) but maybe im wrong the good news is it looks like the issue is limited to that single inference test (based on individual-level permutation) so i'll take a closer look at that function today |
(im fine to go ahead and merge this PR then and work on the failure separately) |
Looks like this started failing 5 days ago. |
That is |
Not sure why pygeos is in requirements and CI ends here as it doesn't seem to be used in the code. Removing.