Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pygeos #210

Merged
merged 1 commit into from Apr 12, 2023
Merged

remove pygeos #210

merged 1 commit into from Apr 12, 2023

Conversation

martinfleis
Copy link
Member

Not sure why pygeos is in requirements and CI ends here as it doesn't seem to be used in the code. Removing.

@martinfleis
Copy link
Member Author

Huh? How come this PR caused a failure? Anyone closer to segregation code can tell me what is wrong?

@knaaptime
Copy link
Member

weird. I'll dig into it

thanks for putting this together

@jGaboardi
Copy link
Member

Very strange indeed. Seems to be coming from deep within joblib/futures?

@jGaboardi
Copy link
Member

How and why removing the pygeos dependency would lead to that path is a bit of mystery...

@martinfleis
Copy link
Member Author

It is not caused by this PR. See main https://github.com/pysal/segregation/actions/runs/4642225334/jobs/8215907349. For some reason, the workflow is marked as successful even when it failed in all envs :D.

@martinfleis
Copy link
Member Author

continue-on-error: true

@knaaptime
Copy link
Member

i thought the continue on error was supposed to just keep running tests on all platforms even when one fails (to make sure its not isolated to windows or something) but maybe im wrong

the good news is it looks like the issue is limited to that single inference test (based on individual-level permutation) so i'll take a closer look at that function today

@knaaptime
Copy link
Member

(im fine to go ahead and merge this PR then and work on the failure separately)

@jGaboardi
Copy link
Member

Looks like this started failing 5 days ago.

@martinfleis
Copy link
Member Author

i thought the continue on error was supposed to just keep running tests on all platforms even when one fails

That is fail-fast.

@knaaptime knaaptime merged commit 5517192 into pysal:main Apr 12, 2023
0 of 9 checks passed
@martinfleis martinfleis deleted the pygeos branch April 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants