Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline unittests #147

Closed
jGaboardi opened this issue Nov 20, 2018 · 2 comments
Closed

Streamline unittests #147

jGaboardi opened this issue Nov 20, 2018 · 2 comments
Assignees

Comments

@jGaboardi
Copy link
Member

Current implementation of unittests is becoming cumbersome:

  • matrix of 4 testing scripts that test:
    • api and developer facing code
    • spatial data read from a .shp and a geopandas.GeoDataFrame

While retaining the basic testing of input, once certain values have been determined to be correct limit testing. For example, if the values of calculation A are equal following a data read from a .shp and a gdf, then calculation B needs only to be performed using the data from either the .shp or gdf, not both. In this way tests will run more quickly and be less time consuming to maintain.

@jGaboardi
Copy link
Member Author

Current scripts:

  1. test_network_api_from_gdf
  2. test_network_api_from_shp
  3. test_network_from_gdf
  4. test_network_from_shp

Merge these down to 2 scripts:

  1. test_network_api
  2. test_network

In each other the two testing scripts:

  • First test that data read in from a .shp and a gdf are equal.
  • Then do the remainder of the unittests from only one of those read methods.

@jGaboardi jGaboardi added this to To do - major in v1.2 release Nov 22, 2018
@jGaboardi
Copy link
Member Author

Resolved in #153

@jGaboardi jGaboardi moved this from To do - major to Done in v1.2 release Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v1.2 release
  
Done
Development

No branches or pull requests

1 participant