plot_spatial_weights including network joins for non_planar_joins
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjsrey
approved these changes
Jun 25, 2018
|
I think this is failing as the example data set in libpysal has not been released. For now you could change the test to install libpysal from master. Guide |
… and `W` Object in `libpysal`
provide doc-string and Examples
extended documentation
|
@sjsrey all green :) |
ljwolf
requested changes
Jun 26, 2018
|
notebook is excellent; dig the styling defaults. |
fix typos in notebook
ljwolf
approved these changes
Jun 26, 2018
This was referenced Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created
splot.libpysaland_viz_libpysal_mpl.pycontainingplot_spatial_weights(),a visualisation showing the spatial weight network and the spatial weight network with new joins in case
libpysal.weights.util.nonplanar_neighbors(weights, gdf)was called.nonplanar_edges_kwsThis pull request builds on top of #13