Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up KNearestPMedian parameters & docstring #423

Closed
Tracked by #414
jGaboardi opened this issue Dec 10, 2023 · 0 comments · Fixed by #424
Closed
Tracked by #414

clean up KNearestPMedian parameters & docstring #423

jGaboardi opened this issue Dec 10, 2023 · 0 comments · Fixed by #424
Assignees
@jGaboardi
Labels
locate rough edge

Comments

@jGaboardi
Copy link
Member

The parameters in KNearestPMedian diverge a bit from the other facility model classes. This should be a simple fix + cleaned up docstrings. And since KNearestPMedian has not yet been part of a release, there will be no need for a deprecation period.
@jGaboardi jGaboardi self-assigned this Dec 10, 2023
jGaboardi added a commit to jGaboardi/spopt that referenced this issue Dec 10, 2023
@jGaboardi
resolve pysal#423
cb93f17
This was referenced Dec 10, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
locate rough edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

parameters & docstring clean up in KNearestPMedian jGaboardi/spopt
1 participant
@jGaboardi