Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] JOSS paper revisions work #200

Merged
merged 5 commits into from Nov 3, 2021
Merged

Conversation

jGaboardi
Copy link
Member

Starting to address #196.

This PR starts the updates to the JOSS paper that incorporates the locate module.

@jGaboardi
Copy link
Member Author

This first commit updates my affiliation and adds @gegen07 as an author with filler for affiliation. Germano, can you post here your affiliation and ORCID. If you don't have one, seehere.

@jGaboardi
Copy link
Member Author

@ljwolf and @qszhao, please also post your ORCIDs and affiliation here (if you would like to be included).

@jGaboardi
Copy link
Member Author

@xf37, I can add the current edits from the google doc into the paper.md manuscript here in this PR or we can do that in a separate PR. When we are satisfied with the manuscript, we can cut a fresh release and let the editor/reviewers know.

@jGaboardi jGaboardi self-assigned this Oct 26, 2021
@jGaboardi jGaboardi added JOSS WIP Work in progress. For discussion and feedback. Do not merge. labels Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #200 (49e9aa8) into main (dec0031) will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #200     +/-   ##
=======================================
+ Coverage   65.1%   65.3%   +0.2%     
=======================================
  Files         23      23             
  Lines       2458    2461      +3     
  Branches     494     494             
=======================================
+ Hits        1600    1607      +7     
+ Misses       786     777      -9     
- Partials      72      77      +5     
Impacted Files Coverage Δ
spopt/region/region_k_means.py 97.3% <0.0%> (-1.3%) ⬇️
spopt/_version.py 33.8% <0.0%> (+1.5%) ⬆️

@qszhao
Copy link

qszhao commented Oct 26, 2021

@ljwolf and @qszhao, please also post your ORCIDs and affiliation here (if you would like to be included).

Thanks @jGaboardi, I am more than happy to be a co-author for this paper. Here is my ORCID and affiliation:

ORCID: https://orcid.org/0000-0002-5549-9457
Affiliation: Urban Big Data Centre, School of Social & Political Sciences, University of Glasgow, Glasgow, G12 8RZ, UK.

@gegen07
Copy link
Member

gegen07 commented Oct 26, 2021

This first commit updates my affiliation and adds @gegen07 as an author with filler for affiliation. Germano, can you post here your affiliation and ORCID. If you don't have one, see here.

ORCID: https://orcid.org/0000-0002-4758-1776
Affiliation: Federal University of Viçosa

@ljwolf
Copy link
Member

ljwolf commented Oct 27, 2021

HI sorry ORCID: https://orcid.org/0000-0003-0274-599X and affil: University of Bristol

@qszhao
Copy link

qszhao commented Oct 27, 2021

@jGaboardi I went through the paper again in the google doc and edited a few places (such as the names of our models!). It will be great if we can also update Figure 2. See my comments there.

@jGaboardi
Copy link
Member Author

@qszhao I will try to get everyone's edits from the google doc to the paper.md from this PR in the coming days, maybe over the weekend. @gegen07 Could you take a look at @qszhao's Figure 2 suggestion and update it? He makes a good point that the figure is in Lon/Lat, but we state a coverage radius in kilometers.

@jGaboardi
Copy link
Member Author

I plan to go ahead with a release, which will be the baseline for our submission, this weekend after implementing the text update in the PR. If there are any detractors, speak now.

paper/paper.md Outdated Show resolved Hide resolved
@jGaboardi
Copy link
Member Author

Tie in with #203

Copy link
Member

@gegen07 gegen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jGaboardi jGaboardi merged commit 7c89cf6 into pysal:main Nov 3, 2021
@jGaboardi jGaboardi deleted the paper_affiliations branch November 3, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JOSS WIP Work in progress. For discussion and feedback. Do not merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants