policy for multiple components in maxp #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjsrey
added
the
WIP
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
=======================================
+ Coverage 65.2% 66.0% +0.7%
=======================================
Files 23 23
Lines 2466 2535 +69
Branches 535 552 +17
=======================================
+ Hits 1609 1672 +63
+ Misses 783 778 -5
- Partials 74 85 +11
|
jGaboardi
approved these changes
Mar 14, 2022
|
TODO
|
knaaptime
reviewed
Mar 15, 2022
spopt/region/maxp.py
Outdated
| return [] | ||
|
|
||
|
|
||
| def plot_components(gdf, w): |
There was a problem hiding this comment.
nice, this can be a really useful check. It might be nice to lift it up into lib...?
There was a problem hiding this comment.
I was thinking the same.
What we could do is leave this here for now, then as part of the next release of lib, migrate this over and have spopt import from lib.
sjsrey
removed
the
WIP
jGaboardi
approved these changes
Mar 15, 2022
sjsrey
changed the title
knaaptime
approved these changes
Mar 16, 2022
|
@sjsrey Is this ready to merge or are you still working on it? |
Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.