Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml – numpy version requirement #124

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

jGaboardi
Copy link
Member

There is no numpy>=1.3. This was probably introduced by typo at some point in the past.

@jGaboardi jGaboardi added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 3, 2023
@jGaboardi jGaboardi self-assigned this Oct 3, 2023
@knaaptime
Copy link
Member

i think im the only one who touched that file, so probably my fault. Thanks for catching

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #124 (5a8f8a2) into main (e57cac0) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #124     +/-   ##
=======================================
- Coverage   69.1%   69.1%   -0.0%     
=======================================
  Files         40      40             
  Lines       8723    8723             
  Branches    1253    1253             
=======================================
- Hits        6027    6024      -3     
- Misses      2316    2319      +3     
  Partials     380     380             

see 1 file with indirect coverage changes

@jGaboardi
Copy link
Member Author

i think im the only one who touched that file, so probably my fault. Thanks for catching

Maybe, but I am seeing it across the ecosystem so it could have also been me (or anyone else).

@jGaboardi jGaboardi merged commit c0ead26 into main Oct 3, 2023
16 checks passed
@jGaboardi jGaboardi deleted the jGaboardi-patch-1 branch October 3, 2023 15:43
@jGaboardi
Copy link
Member Author

Should we cut a fresh release for this, or probably OK to let it ride?

@knaaptime
Copy link
Member

bugfix bump

@jGaboardi
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants