Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster raster #70

Closed
wants to merge 2 commits into from
Closed

Faster raster #70

wants to merge 2 commits into from

Conversation

knaaptime
Copy link
Member

need to do some more extensive profiling, i think, but this resolves #2

@knaaptime
Copy link
Member Author

on second thought im not sure this first attempt will be faster because im rebuilding the table

@renanxcortes
Copy link
Collaborator

Could you make a benchmark comparing both performances? I think you could a small set of polygons.

@knaaptime knaaptime marked this pull request as draft June 4, 2020 20:47
@knaaptime
Copy link
Member Author

will do. For now, i've just been running the dasymeric unit test, a la pytest tobler/tests/test_interpolators.py -k "masked", but i can add some more detailed tests.

currently, this PR helps us move to a single function rather than separating area_interpolate from _slow_area_interpolate but doesnt yield the performance boost. I'm still a little optimistic about the alernative approach i sketched out in the bottom of #2, so gonna continue exploring that

@knaaptime
Copy link
Member Author

ok, i've been down several rabbit holes on this one and my current view is that we can't optimize our current implementation much more. Right now we're dealing with the raster side quite efficiently, and any speedups we might gain on the vector side by using area_tables_binning are far outweighed by the additional raster processing we need to get there

@renanxcortes
Copy link
Collaborator

Any advances in the scanlines approach?

@knaaptime
Copy link
Member Author

no the scanlines stuff has been quiet for awhile, but this is a good reminder to revisit that stuff. Closing this as I'm confident i cant optimize until we get a really fast raster polygonizer

@knaaptime knaaptime closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility of using area_interpolate_binning for the raster approach
2 participants