Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concatenation issue and copy inputs #80

Merged
merged 8 commits into from Aug 7, 2020

Conversation

knaaptime
Copy link
Member

this fixes the concatenation index issue, and also it turns out we were also modifying inputs as well

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #80 into master will increase coverage by 3.60%.
The diff coverage is 93.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   77.59%   81.19%   +3.60%     
==========================================
  Files          11       11              
  Lines         540      569      +29     
==========================================
+ Hits          419      462      +43     
+ Misses        121      107      -14     
Impacted Files Coverage Δ
tobler/area_weighted/area_weighted.py 87.28% <88.88%> (+6.03%) ⬆️
tobler/model/models.py 90.00% <88.88%> (-1.18%) ⬇️
tobler/tests/test_interpolators.py 97.95% <100.00%> (+0.13%) ⬆️
tobler/util/util.py 85.71% <100.00%> (+12.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e4d09...f27cc7e. Read the comment docs.

@knaaptime knaaptime requested a review from sjsrey August 7, 2020 04:53
Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch on the copy.
i think this handles the bug - we need to add the tests.

@knaaptime
Copy link
Member Author

resolves #68 #69 and #6

@knaaptime knaaptime merged commit a1c38a4 into pysal:master Aug 7, 2020
@knaaptime knaaptime deleted the intensivefix branch August 7, 2020 20:23
@knaaptime knaaptime mentioned this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants