New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix concatenation issue and copy inputs #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 77.59% 81.19% +3.60%
==========================================
Files 11 11
Lines 540 569 +29
==========================================
+ Hits 419 462 +43
+ Misses 121 107 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch on the copy.
i think this handles the bug - we need to add the tests.
this fixes the concatenation index issue, and also it turns out we were also modifying inputs as well