You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Instantiating an Instrument via inst_module or via platform and name produce slightly different Instrument objects. Going via inst_module keeps a module attached to the Instrument which breaks inst.copy() and things that depend upon that.
I ended up handling the module objects in the copy method itself. The change to iteration code in v3.0 (to include a copy) meant that inst_module instantiated instruments couldn't iterate in a variety of configurations. Tests were expanded to include an inst_module instantiated Instrument.
Describe the bug
Instantiating an Instrument via
inst_module
or viaplatform
andname
produce slightly different Instrument objects. Going viainst_module
keeps a module attached to the Instrument which breaksinst.copy()
and things that depend upon that.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Removing the inst_module does mean that repr would no longer work. Perhaps it is better to account for inst_module in copy alone?
The text was updated successfully, but these errors were encountered: