Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/BUG: Compatibility with pysatSpaceWeather 0.0.4 #782

Closed
jklenzing opened this issue May 12, 2021 · 1 comment · Fixed by #797
Closed

TST/BUG: Compatibility with pysatSpaceWeather 0.0.4 #782

jklenzing opened this issue May 12, 2021 · 1 comment · Fixed by #797
Assignees
Milestone

Comments

@jklenzing
Copy link
Member

jklenzing commented May 12, 2021

Describe the bug
The ACE and F10.7 instruments have updated platform, name, and tag info in pysatSpaceWeather 0.0.4. These need to be updated in pysat/tests/test_utils_files.py::TestFileDirectoryTranslations.

To Reproduce
See test file and github actions reports in nomerge/file_translate branch for a test run with the release candidate for pysatSpaceWeather.

Desktop (please complete the following information):
Tests only run in a CI environment.

Additional context
A long term solution is suggested in #779. For the near term, the instrument names should be updated and pushed through with the latest patch. See pysat/pysatSpaceWeather#54 for the release candidate.

@jklenzing jklenzing added this to the 3.0.1 Release milestone May 12, 2021
@jklenzing jklenzing self-assigned this May 12, 2021
@jklenzing jklenzing linked a pull request May 21, 2021 that will close this issue
10 tasks
@jklenzing
Copy link
Member Author

Closing with merge of #797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant