Release Candidate 0.0.4 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rc 0.0.2
Reworded comment to be more accurate to current custom functionality.
Reorganized functions to not include functions that cannot be used as custom functions from a block of common custom functions.
Custom style update
V0.0.3 Updates
ENH: Update to latest pysat
Updated the pysat branch used for Travis CI.
Update travis after pysat release. Also added use of `before_install` for environment set up.
Updated tested python versions, removing support for 3.6 and adding support for 3.9.
Added a yaml file for GitHub actions.
Removed tests performed by GitHub actions. Also simplified installation, just using pip and not conda.
Updated changelog, adding a section for the upcoming release.
Made PEP8 improvements.
Added a flake8 ignore flag for line breaks before operators.
Updated links that were being redirected.
Added summary of recent commits to the changelog.
Remove coveralls call from Travis, since this has been moved to GitHub actions.
Attempting to fix the GitHub actions coveralls call.
Replaced tab with spaces.
Fixed coveralls call by fixing pytest command and reverting to old style. Simplified flake8 calls by separating PEP8 requirements and complexity calls.
Removed extra lines from GitHub actionos yaml.
Updated pysat in Travis CI and implemented GitHub actions for most tests.
DOC: update badge
STY: typos
Updated Dst tag to be informative, and easily allow for future additions of historic data from Kyoto.
rstoneback
reviewed
May 17, 2021
rstoneback
reviewed
May 17, 2021
rstoneback
reviewed
May 17, 2021
rstoneback
reviewed
May 18, 2021
Simplified code, removing unnecessary loops. Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
Fixed the metadata re-assignment of the fill value.
Dst update
If the requested file is not present on the server, raise a warning instead of an error.
rstoneback
reviewed
May 18, 2021
There was a problem hiding this comment.
Thanks @aburrell. I did my best to be thorough and check out each of the supported datasets.
Created a general preprocess routine to replace specific fill values with NaN.
Removed preprocess routine now in general.
Improved the examples and warnings in the F10.7 docstrings and applied the general preprocessing routine.
Improved the examples and warnings in the Kp docstrings and applied the general preprocessing routine.
Improved the examples and warnings in the ACE docstrings and applied the general preprocessing routine.
rstoneback
previously approved these changes
May 20, 2021
jklenzing
approved these changes
May 20, 2021
aburrell
commented
May 20, 2021
Fixed float check to identify both numpy floats and normal floats.
aburrell
commented
May 20, 2021
|
Re-requesting a review from @rstoneback since I changed his code lines. |
aburrell
dismissed
rstoneback’s stale review
Changed the code added by @rstoneback, so want his eye on the update.
rstoneback
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alpha release fully compatible with pysat 3.0.0+.
Type of change
How Has This Been Tested?
This has been tested by running examples and unit tests locally
Test Configuration
Checklist:
CHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release