Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing Instrument with bad tag #784

Closed
aburrell opened this issue May 14, 2021 · 1 comment · Fixed by #794
Closed

Initializing Instrument with bad tag #784

aburrell opened this issue May 14, 2021 · 1 comment · Fixed by #794
Labels
Milestone

Comments

@aburrell
Copy link
Member

Describe the bug
Pysat will successfully initialize an instrument with a bad tag or inst_id.

To Reproduce

import pysat
import pysatSpaceWeather as ps_sw
imf = pysat.Instrument(inst_module=ps_sw.instruments.ace_mag, clean_level='clean', tag='hi', inst_id='fun')
print(imf)

pysat Instrument object
-----------------------
Platform: 'ace'
Name: 'mag'
Tag: 'hi'
Instrument id: 'fun'

Data Processing
---------------
Cleaning Level: 'clean'
Data Padding: <DateOffset: minutes=10.0>
Keyword Arguments Passed to list_files: {}
Keyword Arguments Passed to load: {}
Keyword Arguments Passed to preprocess: {}
Keyword Arguments Passed to download: {}
Keyword Arguments Passed to list_remote_files: {}
Keyword Arguments Passed to clean: {}
Keyword Arguments Passed to init: {}
Custom Functions: 0 applied

Local File Statistics
---------------------
Number of files: 0


Loaded Data Statistics
----------------------
No loaded data.


Expected behavior
Pysat should fail with an informative warning if initialized with an unknown tag or inst_id.

Desktop (please complete the following information):

  • OS: OS X Mojave
  • Version python 3.7
  • Other details about your setup that could be relevant: RC branch of pysatSpaceWeather
@aburrell aburrell added the bug label May 14, 2021
@rstoneback
Copy link
Collaborator

See #537

@jklenzing jklenzing added this to the 3.0.1 Release milestone May 19, 2021
@rstoneback rstoneback linked a pull request May 20, 2021 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants