Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3.0.2rc #1014

Merged
merged 1,625 commits into from
Jul 22, 2022
Merged

V3.0.2rc #1014

merged 1,625 commits into from
Jul 22, 2022

Conversation

rstoneback
Copy link
Collaborator

@rstoneback rstoneback commented May 26, 2022 •
edited

Description

Addresses #

v3.0.2 Release Candidate

Type of change

Please delete options that are not relevant.

  • Version release

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

  • unit test suite

Test Configuration:

  • Operating system: Mac
  • Version number: Python 3.9
  • Any details about your local setup that are relevant

Checklist:

  • Update the version number
  • Verify and update Zenodo information in .zenodo.json
  • doc tests pass locally
  • activate this branch on readthedocs (pysat docs)
  • Upload the test distribution to the testPyPi server
  • Contacted developers and users about the future release
  • Performed integration tests with downstream packages (include list of these packages)
  • Create a wiki page with the release text (link)
  • After approval, confirm all changes from the RC pull are listed in the wiki release text.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

rstoneback and others added 30 commits April 25, 2022 16:00
@rstoneback
DOC: Updated changelog
88cb464
@rstoneback
BUG: Removed specific check for epoch in dimensions
f4aecbe
@rstoneback
ENH: Expanded range of metadata read from file via xarray
b89c216
@rstoneback
BUG: Updated readme note about 'data_dirs'
88ea563
@rstoneback
BUG: Updated readme note about 'data_dirs'
55a3558
@rstoneback
STY: Comment on windows open resource
6c4ae10
@rstoneback
ENH: Update tag default and docstring for test Instruments
db11a0c
@rstoneback
DOC: Update changelog
b1b1601
@rstoneback
STY: inst_id docstring and defaults update
fa9c552
@rstoneback
STY: inst_id standard update and data_path check removal
ba257e2
@rstoneback
STY: Update changelog
4c1c0aa
@rstoneback
TST: Remove directory path test
456a712
@rstoneback
STY: None -> ''
9d29aa1
@rstoneback
DOC: Docstring/comment improvements
1901bd3
@rstoneback
STY: docstring standard improvement
04be30a
@rstoneback
STY: Docstring improvements
9e35c05
@rstoneback
TST: Test requires update_files to be True
c3d46db
@rstoneback
TST: directory_format -> data_dir correction
b4c2ac2
@rstoneback @aburrell
Apply suggestions from code review
149b635 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@rstoneback
DOC: None -> '' plus tweaks I saw along way
cb16376
@rstoneback
DOC: Second review pass
95a2d0e
@rstoneback
Merge remote-tracking branch 'origin/tag_update' into tag_update
0ce6bcb
@rstoneback
Merge pull request #996 from pysat/tag_update
00d2449 
STY: Tag/inst_id/data_path standard update
@rstoneback
STY: Review
3de2cd8
@rstoneback
STY: Review
8512943
@rstoneback
STY: pysat.Instrument docstring review
81e5ab0
@rstoneback
STY: Review
b87a597
@rstoneback
STY: Review
a70644d
@rstoneback
STY: Review
3dbde31
@rstoneback
STY: Review
bbfff61
@rstoneback
Copy link
Collaborator Author

Thanks for the feedback!

aburrell
aburrell reviewed Jul 19, 2022
View reviewed changes
pysat/tests/test_orbits.py Outdated
inst : pysat.Instrument
The instrument to be filtered
times : array of dt.datetimes
A 2xN array consisting of the start and stop of each gap in a list of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this (2N, ) or (2, N) in shape? Recommend using the correct one of these expressions in the docstring.

pysat/tests/test_orbits.py Outdated Show resolved Hide resolved
pysat/tests/test_orbits.py Outdated Show resolved Hide resolved
pysat/tests/test_orbits.py Outdated Show resolved Hide resolved
pysat/tests/test_methods_testing.py Outdated Show resolved Hide resolved
pysat/tests/test_files.py Outdated Show resolved Hide resolved
pysat/tests/test_constellation.py Outdated Show resolved Hide resolved
pysat/tests/test_constellation.py Outdated Show resolved Hide resolved
pysat/tests/classes/cls_instrument_library.py Outdated Show resolved Hide resolved
pysat/tests/classes/cls_instrument_library.py Show resolved Hide resolved
@rstoneback rstoneback mentioned this pull request Jul 19, 2022
Open
@rstoneback
Copy link
Collaborator Author

I didn't see any warnings for assigning to a copy so I went ahead and made things a bit more official for future tracking.

@rstoneback rstoneback requested a review from aburrell July 19, 2022 21:04
aburrell
aburrell reviewed Jul 20, 2022
View reviewed changes
pysat/_meta.py Show resolved Hide resolved
pysat/_meta.py Outdated Show resolved Hide resolved
pysat/tests/classes/cls_instrument_library.py Outdated Show resolved Hide resolved
pysat/tests/test_constellation.py Outdated Show resolved Hide resolved
@rstoneback @aburrell
Apply suggestions from code review
645f25d 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@rstoneback rstoneback requested a review from aburrell July 21, 2022 15:13
aburrell
aburrell approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐴

@rstoneback rstoneback merged commit b1834eb into main Jul 22, 2022
@rstoneback rstoneback deleted the v3-0-2rc branch July 22, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburrell aburrell aburrell approved these changes

@jklenzing jklenzing jklenzing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rstoneback @aburrell @jklenzing