-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: remove support for meta children and 2d pandas #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback as an intermediate review.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
…t/pysat into maint/789_913_meta_children
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_meta.py
lines 401 and 442 are newly uncovered, recommend adding an instance where meta is setting bytes instead of a string.
Also have a new uncovered line in io.py
on line 1615 that could be addressed with a test for inst_to_netcdf
that has a DataFrame of DataFrames to trip the ValueError.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Not sure why these show up as newly uncovered. Neither are covered in |
Looking at this one, other errors get tripped before we get here since this format is not allowed. I think we can delete this line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more lines uncovered that haven't been discussed, but I can't think of straightforward ways to test them
@JonathonMSmith yeah, there are a few things that could be done, but since there aren't new uncovered lines, I think that's best addressed in another branch. |
Description
Addresses #789 and #913
Removes the support for storing pandas DataFrames within other DataFrames, including
pysat_testing2d
instrumentType of change
to not work as expected)
How Has This Been Tested?
Tested against other pysat packages (ran vs this branch and pysat develop to see if new errors occur)
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release