Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: network lock cleanup #1157

Merged
merged 7 commits into from
Nov 27, 2023
Merged

TST: network lock cleanup #1157

merged 7 commits into from
Nov 27, 2023

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Nov 23, 2023

Description

Addresses #871

Tidies up issues regarding network lock tests.

  • Remove todo
  • use temporary directory for files created

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

via pytest

Test Configuration:

  • Operating system: Ventura
  • Version number: Python 3.10.9

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing
Copy link
Member Author

Added 'continue-on-error' flag to coveralls to (tentatively) solve 422 problem.

Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this cause such a huge drop in coverage?

@jklenzing
Copy link
Member Author

How did this cause such a huge drop in coverage?

Probably because the pulls are not being run

@jklenzing
Copy link
Member Author

How did this cause such a huge drop in coverage?

Inspecting the files, a lot of the uncovered lines are docstrings. Not sure if this is a result of not configuring the coveralls app correctly.

@jklenzing jklenzing merged commit 163b056 into develop Nov 27, 2023
19 checks passed
@jklenzing jklenzing deleted the tst/871_network_lock branch November 27, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants