-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: network lock cleanup #1157
Conversation
Added 'continue-on-error' flag to coveralls to (tentatively) solve 422 problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this cause such a huge drop in coverage?
Probably because the pulls are not being run |
Inspecting the files, a lot of the uncovered lines are docstrings. Not sure if this is a result of not configuring the coveralls app correctly. |
Description
Addresses #871
Tidies up issues regarding network lock tests.
Type of change
How Has This Been Tested?
via pytest
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release