-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: Completed funding institution list #1168
Conversation
TODO: update with single acknowledgments file and point to this from the individual files |
I added the acknowledgements and added a test sentence for pointing to acknowledgements.txt
|
Apologies for stringing out the pushes. I am out of practice :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider finding a way to pipe the acknowledgements.txt lines into zenodo using the "notes" section.
Co-authored-by: Jeff Klenzing <19592220+jklenzing@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend moving 'acknowledgements.txt' to 'ACKNOWLEDGEMENTS.md', to be consistent with the naming conventions of the rest of the informative files in this directory.
I've found the notes section of the .zenodo.json but .json itself doesn't have functionality to load a file. Zenodo, according to its docs, interprets the notes portion of the .json as a string (html supported). Within html we'd need something like javascript to actually load the file, presuming Zenodo would allow that code to access files.... In other words, I currently don't see how to connect the acknowledgments into zenodo unless we manually copy with each release. |
Addresses #1168
Description
Completes the list of funding institutions from most awesome down to NASA
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Visual inspection of the RTD generated docs
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release