-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH/BUG: Filename fix for #1173 #1174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding type to file formatting.
Added the ability for pysat to identify files that shouldn't be considered based on the expected value type of the identifying key.
Fixed index use in `parse_delimited_filenames`.
Updated the file tests to include the new dict output and test for bad file removal by index.
Fixed another instance of the wrong index.
Removed old line from header.
Set the default type for time parameters to be int, if none is supplied.
Test file removal by bad format specifier.
Removed extra whitespace.
Updated the changelog.
Coverage drop appears to be a rounding error. |
Remove a clean flag that stand in the way of this test passing.
jklenzing
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1173 by introducing consideration of supplied type when parsing filename formats.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran using a modified example from the test case:
The output should not have the second file in
files
as a viable output file.Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release