Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: tidy tests #1180

Merged
merged 3 commits into from
Feb 26, 2024
Merged

MAINT: tidy tests #1180

merged 3 commits into from
Feb 26, 2024

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Feb 21, 2024

Description

Not all the testing suite methods clean up after themselves. Found during troubleshooting for pysatCDAAC.

Other minor tweaks to get check marks up and running:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

running against pysatMissions.

Test Configuration:

  • Operating system: Ventura 13.6.2
  • Version number: Python 3.10.9
  • Any details about your local setup that are relevant

Checklist:

  • [rc] Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing
Copy link
Member Author

pinging @aburrell

@jklenzing jklenzing merged commit c05bcc5 into rc_3_2_0 Feb 26, 2024
29 checks passed
@jklenzing jklenzing deleted the maint/clean_testing branch February 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants