TIEGCM comparison additions #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into tiegcm_comparison
|
Adding latest develop commits to sort out recent testing bugs. |
|
Thanks Jeff!
On Jun 4, 2019, at 9:22 AM, Jeff Klenzing <notifications@github.com<mailto:notifications@github.com>> wrote:
Adding latest develop commits to sort out recent testing bugs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#232>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA3N26PVIVCLSK6FJB42RYDPYWYSTANCNFSM4HSUW2LQ>.
|
jklenzing
reviewed
Jun 4, 2019
| def satellite_view_through_model(sat, tie, scoords, tlabels): | ||
| """Interpolates model values onto satellite orbital path. | ||
|
|
||
| """ |
There was a problem hiding this comment.
needs proper docstring #TheEyeOfBurrell
jklenzing
requested changes
Jun 4, 2019
|
Added a tentative docstring based on my reading of the code. Also generalized inputs in case a string rather than a list of strings is input for either scoords or tlabels. @rstoneback, am I interpreting this right? |
jklenzing
reviewed
Jun 16, 2019
|
Thanks for iterating on this Jeff. The module itself needs a bit of work. Parts of the data are linear, others are log. I need to work on ensuring consistency.
Already in Santa Fe?
On Jun 16, 2019, at 3:25 PM, Jeff Klenzing <notifications@github.com<mailto:notifications@github.com>> wrote:
@jklenzing commented on this pull request.
Tiegcm tag labels refer to IVM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#232>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA3N26M7SOLXTBLM4W4MUQLP22ORVANCNFSM4HSUW2LQ>.
|
|
DFW airport. Was talking with Asher about TIEGCM capabilities, which is how I noticed this. |
|
Heh. Sounds like everyone is at the same gate. I should mosey back that way.
On Jun 16, 2019, at 3:38 PM, Jeff Klenzing <notifications@github.com<mailto:notifications@github.com>> wrote:
DFW airport. Was talking with Asher about TIEGCM capabilities, which is how I noticed this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#232>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA3N26LILYOOOP2HPBJVYRDP22QDPANCNFSM4HSUW2LQ>.
|
|
Just switched to E35. |
jklenzing
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull includes a bugfix for the file format keyword in tiegcm. It also includes a first pass at fast interpolation for TIEGCM values along the satellite track. The method is sound but still needs to be updated to account for the log scaling of some TIEGCM parameters.
Creating this pull now before I forget about the changes II made a few months ago.